crossplane-contrib / provider-upjet-aws

Official AWS Provider for Crossplane by Upbound.
https://marketplace.upbound.io/providers/upbound/provider-aws
Apache License 2.0
137 stars 112 forks source link

fix(rds): fix late init for rds clusterinstance #1326

Closed haarchri closed 1 month ago

haarchri commented 1 month ago

Description of your changes

After upgrading the Version in the Cluster the ClusterInstance gets stuck in an update-loop because of the engineVersion spec.forProvider.engineVersion

2024-05-15T14:49:54Z    DEBUG    provider-aws    Diff detected    {"uid": "31f30f84-59ed-4720-ad3a-93aae50eb27d", "name": "xxx", "gvk": "rds.aws.upbound.io/v1beta1, Kind=ClusterInstance", "instanceDiff": "*terraform.InstanceDiff{mu:sync.Mutex{state:0, sema:0x0}, Attributes:map[string]*terraform.ResourceAttrDiff{\"engine_version\":*terraform.ResourceAttrDiff{Old:\"15.5\", New:\"15.4\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}}, Destroy:false, DestroyDeposed:false, DestroyTainted:false, RawConfig:cty.NilVal, RawState:cty.NilVal, RawPlan:cty.NilVal, Meta:map[string]interface {}(nil)}"}
2024-05-15T14:49:54Z    DEBUG    provider-aws    Successfully requested update of external resource    {"controller": "managed/rds.aws.upbound.io/v1beta1, kind=clusterinstance", "request": {"name":"xxx"}, "uid": "31f30f84-59ed-4720-ad3a-93aae50eb27d", "version": "15401705", "external-name": "xxx", "requeue-after": "2024-05-15T15:00:05Z"}

spec.forProvider.dbParameterGroupName

The parameter group default.aurora-postgresql15 with DBParameterGroupFamily aurora-postgresql15 can't be used for this instance. Use a parameter group with DBParameterGroupFamily aurora-postgresql16.

spec.forProvider.preferredBackupWindow

The requested DB Instance will be a member of a DB Cluster. Set backup window for the DB Cluster.",

Fixes #

I have:

How has this code been tested

--- PASS: kuttl (1339.64s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (1338.83s)
PASS
13:31:56 [ OK ] running automated tests

Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9223450840

haarchri commented 1 month ago

/test-examples="examples/rds/v1beta1/clusterinstance.yaml"