crossplane-contrib / provider-upjet-aws

Official AWS Provider for Crossplane by Upbound.
https://marketplace.upbound.io/providers/upbound/provider-aws
Apache License 2.0
137 stars 112 forks source link

Make SSO examples uptestable #1350

Open mbbush opened 3 weeks ago

mbbush commented 3 weeks ago

Description of your changes

I noticed when doing https://github.com/crossplane-contrib/provider-upjet-aws/pull/1349 that some of the ssoadmin resources have an external name configuration that uses index to extract a value that appears in a singleton object. These seemed like good candidates to test with these changes.

I'm pleased to report that :heavy_check_mark: the tests pass with no issues for all the v1beta1 and v1beta2 manifests in both identitystore and ssoadmin. Logs are attached. Note that because I deliberately used unique names for each resource when I first wrote these example manifests, I was able to uptest them all at once (per api version), which was quite fast.

I also made the ssoadmin and identitystore resources uptestable by using an uptest datasource.

In order for these to pass with the config used in github actions, someone from upbound will need to:

Note on aws terminology: IAM Identiy Center is the current name for what aws originally launched as "sso" and "identity store". We still have the old names in the SDK, but the console uses the new marketing names.

Fixes #

I have:

How has this code been tested

ssoadmin-v1beta1.logs.txt ssoadmin-v1beta2.logs.txt identitystore.logs.txt

turkenf commented 1 week ago

/test-examples="examples/identitystore/v1beta1/group.yaml"

turkenf commented 1 week ago

/test-examples="examples/ssoadmin/v1beta1/permissionset.yaml"

turkenf commented 1 week ago

Thanks for this PR @mbbush,

I added values ​​for identity_store_id and sso_instance_arn to the data source but I'm not sure if the test account is authorized or not.