Use ARN as external name for aws_iam_role

[gadiener]

Description of your changes

In this PR I'm changing the external name for aws_iam_role to use the role path and name instead of just the role name. Role names are not unique IDs and it is possible to have in the same AWS account multiple role with the same name but with different paths.

I see the Terraform provider is also using the role name as ID please let me know if you have a better suggestion.

Fixes #1376

I have:

• [x] Read and followed Crossplane's contribution process.
• [x] Run make reviewable to ensure this PR is ready for review.
• [x] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Executed tests in the CI, it's not very clear to me how to test this locally, I'd appreciate an hint on that

[gadiener]

/test-examples="examples/iam/v1beta1/role.yaml"

[gadiener]

/test-examples="examples/iam/v1beta1/rolepolicy.yaml"

[gadiener]

I just found the file /config/externalname.go would it be better to apply this change there?

[gadiener]

/test-examples="examples/iam/v1beta1/role.yaml"

[gadiener]

Hi @turkenf sorry for pinging you directly. I'd really appreciate a comment from you on the solution and an hint on what is going on with the failing tests. Thanks

[turkenf]

Hi @gadiener,

Many thanks for your interest and effort. I won't be able to look at this PR soon due to other priorities. But I will try to look at this next week.

[gadiener]

Thanks a lot @turkenf 🙏🏻

[gadiener]

Sure, let's discuss in the issue. I'll keep that open for now