Add //nolint:gocyclo to resource configuration files, config/*/config.go, that didn't have it.
In the ones that have it, but in the form // nolint:gocyclo, replace it with //nolint:gocyclo, which seems to be the standard form going forward.
//nolint:gocyclo has been our de facto solution to cyclomatic complexity errors in resource configuration files. Cyclomatic complexity doesn't really apply to resource configurations. Configurations contain limited business logic, if any, which is independent between resources, even if they are defined inside the same function.
Our linter takes a long time to complete. Discovering the cyclomatic complexity error after a standard resource configuration introduces unnecessary latency to our release process. Here is the latest example: https://github.com/crossplane-contrib/provider-upjet-aws/pull/1528
Description of your changes
//nolint:gocycloto resource configuration files,config/*/config.go, that didn't have it.// nolint:gocyclo, replace it with//nolint:gocyclo, which seems to be the standard form going forward.//nolint:gocyclohas been our de facto solution to cyclomatic complexity errors in resource configuration files. Cyclomatic complexity doesn't really apply to resource configurations. Configurations contain limited business logic, if any, which is independent between resources, even if they are defined inside the same function.Our linter takes a long time to complete. Discovering the cyclomatic complexity error after a standard resource configuration introduces unnecessary latency to our release process. Here is the latest example: https://github.com/crossplane-contrib/provider-upjet-aws/pull/1528
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.~How has this code been tested
See the result of the linter job.