crossplane-contrib / provider-upjet-aws

AWS Provider for Crossplane.
https://marketplace.upbound.io/providers/upbound/provider-family-aws/
Apache License 2.0
146 stars 123 forks source link

ElastiCache Cluster CRD does not create a K8s secret #426

Closed shivasdp closed 2 weeks ago

shivasdp commented 1 year ago

What happened?

When creating a CacheCluster CRD for redis, no kubernetes secret is created containing the details required for establishing a connection to redis, e.g.

endpoint url
port
authtoken or username+password

Refer to the bug which is there in community edition https://github.com/crossplane-contrib/provider-aws/issues/551

How can we reproduce it?

---
apiVersion: elasticache.aws.upbound.io/v1beta1
kind: Cluster
metadata:
  name: "test-cache-cluster"
spec:
  forProvider:
    region: us-east-1
    tags:
      Application: TEST-UM
      Group: QA
      Environment: QA
    engine: redis
    nodeType: cache.t2.micro
    numCacheNodes: 1
    parameterGroupNameRef:
      name: "test-cache-param-grp-1"
    subnetGroupNameRef:
      name: "test-cache-sn-grp1"
    securityGroupIds:
    - sg-004209965c448fbe3
  providerConfigRef:
    name: qa-proconf

  writeConnectionSecretToRef:
    name: cache-cluster-qa-redis-secret
    namespace: test
# k get -n test secret cache-cluster-qa-redis-secret

NAME                             TYPE                                DATA   AGE
cache-cluster-qa-redis-secret   connection.crossplane.io/v1alpha1   0      30h

What environment did it happen in?

svscheg commented 1 year ago

The issue has been reproduced. Need investigate if we can add described in issue information.

aiell0 commented 5 months ago

I am seeing this issue as well, any update here?

turkenf commented 5 months ago

@aiell0, you can add additional sensitive fields to config/elasticache/config.go, and open a PR. We can evaluate the fields you want on the PR.

For more details: Additional Sensitive Fields and Custom Connection Details

github-actions[bot] commented 1 month ago

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

github-actions[bot] commented 2 weeks ago

This issue is being closed since there has been no activity for 14 days since marking it as stale. If you still need help, feel free to comment or reopen the issue!