crossplane-contrib / provider-upjet-aws

AWS Provider for Crossplane.
https://marketplace.upbound.io/providers/upbound/provider-family-aws/
Apache License 2.0
146 stars 123 forks source link

ECS Provider refs and selectors that are missing #467

Closed jpoley closed 1 month ago

jpoley commented 1 year ago

ECS Service and TaskDefinition has some places where using a Ref/Selector would make it easy use / reference the specific Arns

ECS Service

apiVersion: ecs.aws.upbound.io/v1beta1 kind: Service spec.forProvider.loadBalacner[].targetGroupArn #crossplane has it

ECS TaskDefinition

apiVersion: ecs.aws.upbound.io/v1beta1 kind: TaskDefinition spec.forProvider.executionRoleArn #crossplane has it spec.forProvider.taskRoleArn #crossplane has it

The community provider has these specific Arn selectors, without them you can't seamlessly use ECS Fargate at all. (you would be forced to do cut and paste yaml after obtaining the appropriate ARNs.

svscheg commented 1 year ago

Hi @jpoley ! Thank you for reporting the issue.

Need clarify some information. Firstly could you please attach provider version?

Also for the ECS TaskDefinition spec.forProvider.executionRoleArn we have Ref/Selector for this attribute in the latest version provider-aws: Image

And need to confirm that we need to add Ref/Selector(as on screed for the executionRole attribute) for next attributes:

ECS Service->spec.forProvider.loadBalacner[].targetGroupArn ECS TaskDefinition->spec.forProvider.taskRoleArn

mhoshi-vm commented 10 months ago

i think for ECS service was solved via #831

github-actions[bot] commented 2 months ago

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

github-actions[bot] commented 1 month ago

This issue is being closed since there has been no activity for 14 days since marking it as stale. If you still need help, feel free to comment or reopen the issue!