sterziev88
commented
1 year ago Hi @oblogic7 I am using tgw created with crossplane upbound provider 0.38 and attach VPCs from other accounts to it. That is what I have and what I use:
- I create Resource Share Access in let say account A with terraform ( because at the moment crossplane does not upbound provide option to add principals ). That RAM connects 3 account A B and C.
- Then I create tgw with crossplane with that code:
transitGateway:
name: "tgw-crossplane"
annotations: {}
labels:
createdByCrossplane: "true"
region: "${AWS_REGION}"
autoAcceptSharedAttachments: enable
tags:
Name: tgw-crossplane
createdByCrossplane: "true"
- Attach that tgw to my RAM with crossplane through resource-association:
resourceAssociations:
- name: "resource-association-crossplane" annotations: {} labels: {} region: "eu-west-1" resourceArn: "***" resourceShareArn: "${TGW_RA_SHARE_ARN}"
- Attach other VPCs to that tgw:
vpcAttachment:
- name: "mgmt-vpc-attachment"
annotations: {}
labels: {}
region: "${AWS_REGION}"
vpcId: "${MGMT_VPCID}"
transitGatewayIdSelector:
matchLabels:
createdByCrossplane: "true"
subnetIds:
- "${MGMT_PRIVATE_SUBNET_1}"
- "${MGMT_PRIVATE_SUBNET_2}"
- name: "mgmt-vpc-attachment"
annotations: {}
labels: {}
region: "${AWS_REGION}"
vpcId: "${MGMT_VPCID}"
transitGatewayIdSelector:
matchLabels:
createdByCrossplane: "true"
subnetIds:
- Attach that tgw to my RAM with crossplane through resource-association:
resourceAssociations:
With that configuration my TransitGatewayVpcAttachment works without accepter part. I think that is because I use "autoAcceptSharedAttachments: enable " in my tgw creation... I am not sure but that works for me.
oblogic7
AliAllomani
What happened?
I am attempting to attach a crossplane managed VPC to an existing transit gateway using
TransitGatewayVpcAttachmentandTransitGatewayVpcAttachmentAccepterresources. TheTransitGatewayVpcAttachmentcreates the attachment request and I can see the attachment pending acceptance in the AWS console. However, when I add theTransitGatewayVpcAttachmentAccepterresource, the pending attachment is not accepted, but I do see that crossplane labels are added to the resource. All API calls appear to be successful according to the logs. I was unable to reproduce this issue using Terraform with the same provider version, so this doesn't appear to be a TF provider issue.How can we reproduce it?
MR:
Composition/XRD:
What environment did it happen in?
1.13.1and1.12.20.38and0.37Server Version: version.Info{Major:"1", Minor:"23+", GitVersion:"v1.23.17-eks-a5565ad", GitCommit:"23f44c7dd4e8e23856387345e7cb80bf0f93ced6", GitTreeState:"clean", BuildDate:"2023-06-15T21:19:39Z", GoVersion:"go1.19.6", Compiler:"gc", Platform:"linux/amd64"}EKS