Conditional Nil Pointer Exception Possible

[humoflife]

What happened?

The code at https://github.com/upbound/provider-aws/blob/f6c9172be641b50fee8e5c24612069465b33673e/internal/controller/eks/clusterauth/eks.go#L59 makes the assumption that all users of ClusterAuth MR resource would be using a Selector/Ref and not directly the ClusterName, and the code generated extractor is the one filling the ClusterName field only after its ref.Cluster is Active. When the assumption is false, the provider will experience a nil pointer exception.

Please check for nil ahead of using cluster.CertificateAuthority.Data.

How can we reproduce it?

Do not use a Selector/Ref for the ClusterAuth MR resource. Create a scenario where cluster.CertificateAuthority would be nil when reaching line 59 at https://github.com/upbound/provider-aws/blob/f6c9172be641b50fee8e5c24612069465b33673e/internal/controller/eks/clusterauth/eks.go#L59.

What environment did it happen in?

• Crossplane Version: 1.13
• Provider Version: 0.38.0+
• Kubernetes Version: 1.27
• Kubernetes Distribution: EKS

[github-actions[bot]]

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.