search

crossplane-contrib / provider-upjet-aws

AWS Provider for Crossplane.
https://marketplace.upbound.io/providers/upbound/provider-family-aws/
Apache License 2.0
146 stars 123 forks source link

Docs BucketLifecycleConfiguration: Incorrect deprecation warning of rule.filter.prefix #885

Closed thekaleidoscope closed 5 months ago

thekaleidoscope commented 1 year ago

What happened?

Documentation of rule-filter-prefix warns its deprecated and recommends to use the same filter.prefix field which it's warning for.

rule.filter.prefix: DEPRECATED Use filter instead. This has been deprecated by Amazon S3. Prefix identifying one or more objects to which the rule applies. Defaults to an empty string ("") if filter is not specified.

How can we reproduce it?

Go to https://marketplace.upbound.io/providers/upbound/provider-aws/v0.40.0/resources/s3.aws.upbound.io/BucketLifecycleConfiguration/v1beta1#doc:spec-forProvider-rule-filter-prefix

What environment did it happen in?

N/A

turkenf commented 1 year ago

@thekaleidoscope, this parameter seems to be deprecated, please see here for more information. I am closing this now, feel free to reopen.

applike-ss commented 5 months ago

@turkenf If i am not reading the terraform docs wrong, then it is deprecated on rule.prefix, but not on rule.filter.0.prefix. See: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_lifecycle_configuration

How else would one set a prefix here?

AWS Doc also doesn't show a deprecation for the parameter: https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutBucketLifecycleConfiguration.html

Please re-open or tell me where i'm wrong.

turkenf commented 5 months ago

Hey @applike-ss, you are right, I appreciate your warning 🙏 , I opened a PR that fixed it.