azure.network: `PrivateDNSZoneVirtualNetworkLink` is getting to Synced=False state after provisioning

[ytsarev]

What happened?

I've hit the issue similar to https://github.com/crossplane/terrajet/issues/158 with recently configured azurerm_private_dns_zone_virtual_network_link

----
  Warning  CannotObserveExternalResource  4m24s (x128 over 151m)  managed/network.azure.upbound.io/v1beta1, kind=privatednszonevirtualnetworklink  cannot run plan: plan failed: Instance cannot be destroyed: Resource azurerm_private_dns_zone_virtual_network_link.example has lifecycle.prevent_destroy set, but the plan calls for this resource to be destroyed. To avoid this error and continue with the plan, either disable lifecycle.prevent_destroy or reduce the scope of the plan using the -target flag.: File name: main.tf.json

How can we reproduce it?

kubectl apply -f privatedns-all-in-one.yaml

and wait a bit

What environment did it happen in?

• Crossplane Version: universal-crossplane-1.6.3-up.1
• Provider Name: provider-azure
• Provider Version: dcb79af65f6a359ada7ad4dac049ed0ca292359b

[turkenf]

Hi @ytsarev, I could not reproduce this issue, can you check it again?

  conditions:
  - lastTransitionTime: "2023-05-04T14:12:34Z"
    reason: ReconcileSuccess
    status: "True"
    type: Synced
  - lastTransitionTime: "2023-05-04T14:13:52Z"
    reason: Available
    status: "True"
    type: Ready
  - lastTransitionTime: "2023-05-04T14:13:21Z"
    reason: Success
    status: "True"
    type: LastAsyncOperation
  - lastTransitionTime: "2023-05-04T14:13:21Z"
    reason: Finished
    status: "True"
    type: AsyncOperation
> kubectl get privatednszonevirtualnetworklink.network.azure.upbound.io/example
NAME      READY   SYNCED   EXTERNAL-NAME   AGE
example   True    True     example         29m

[ytsarev]

@turkenf if it works with the recent provider-azure version, I trust your testing :) Feel free to close this one