[Bug]: LastAsyncOperation is failed, but resource has been marked as ready

hannupiki-eficode commented 3 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Affected Resource(s)

At least these two:

network.azure.upbound.io/v1beta1 - ApplicationGateway
managedidentity.azure.upbound.io/v1beta1 - FederatedIdentityCredential

Resource MRs required to reproduce the bug

No response

Steps to Reproduce

Create ApplicationGateway with proper configuration that does deploy it successfully
Add spec.forProvider.authenticationCertificate object with invalid name
Observe LastAsyncOperation and verify that resource status is still ready

If you use nested compositions, deploy ApplicationGateway into child composition and verify that also parent composition is showing everything as ready.

What happened?

Expected: Resource and compositions would be reporting resource as failed in all levels (parent and child composition and resource itself). Observed: Resource, its composition and parent composition are showing everything as ready. Resource's LastActivityOperation is showing an error that prevents applying the change and therefor resource isn't matching the state that have been written into Git and pushed into cluster from there.

In these screenshots you see obvious failure that is rightfully failing, but also how these resources do look like with common ways of checking their status:

Output from kubectl get managed