Remove the Terraform CLI from the provider package - Githubissues

crossplane-contrib / provider-upjet-azuread

AzureAD Provider for Crossplane.

https://marketplace.upbound.io/providers/upbound/provider-azuread/

Apache License 2.0

6 stars 19 forks source link

Remove the Terraform CLI from the provider package #89

Closed ulucinar closed 12 months ago

ulucinar commented 12 months ago

Description of your changes

With #86, we have switched to the Terraform plugin SDK-based reconciliation for all the available managed resources in this provider. This PR removes the Terraform CLI and the Terraform AzureAD provider binaries from the built provider package. We still need to generate the config/schema.json for diff detection purposes and we are planning to address the issue of generating the schema.json without the TF CLI in a follow-up PR.

We may consider keeping the Crossplane provider command-line args intact (but deprecate them) to prevent any breaking changes.

I have:

[x] Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Via the uptest runs below and manually via the package index.docker.io/ulucinar/provider-azuread:v0.14.0-48fe511f83b394ef64a97487fd330f782f4a82e3 built from this PR.

turkenf commented 12 months ago

/test-examples="examples/applications/application.yaml"

turkenf commented 12 months ago

/test-examples="examples/applications/application.yaml"

turkenf commented 12 months ago

/test-examples="examples/administrativeunits/unit.yaml"

turkenf commented 12 months ago

/test-examples="examples/conditionalaccess/accesspolicy.yaml"

turkenf commented 12 months ago

/test-examples="examples/directoryroles/customdirectoryrole.yaml"

turkenf commented 12 months ago

/test-examples="examples/groups/member.yaml"

turkenf commented 12 months ago

/test-examples="examples/serviceprincipaldelegated/permissiongrant.yaml"

turkenf commented 12 months ago

/test-examples="examples/serviceprincipals/principal.yaml"

turkenf commented 12 months ago

/test-examples="examples/synchronization/job.yaml"

turkenf commented 12 months ago

/test-examples="examples/applications/certificate.yaml"

turkenf commented 12 months ago

/test-examples="examples/applications/federatedidentitycredential.yaml"

turkenf commented 12 months ago

/test-examples="examples/applications/password.yaml"

turkenf commented 12 months ago

/test-examples="examples/applications/preauthorized.yaml"

turkenf commented 12 months ago

/test-examples="examples/conditionalaccess/location.yaml"

turkenf commented 12 months ago

/test-examples="examples/directoryroles/role.yaml"

turkenf commented 12 months ago

/test-examples="examples/directoryroles/roleassignment.yaml"

turkenf commented 12 months ago

/test-examples="examples/groups/group.yaml"

turkenf commented 12 months ago

/test-examples="examples/policies/claimsmappingpolicy.yaml"

turkenf commented 12 months ago

/test-examples="examples/serviceprincipals/password.yaml"

turkenf commented 12 months ago

/test-examples="examples/serviceprincipals/certificate.yaml"

turkenf commented 12 months ago

/test-examples="examples/serviceprincipals/claimsmappingpolicyassignment.yaml"

turkenf commented 12 months ago

/test-examples="examples/serviceprincipals/tokensigningcertificate.yaml"

turkenf commented 12 months ago

/test-examples="examples/synchronization/secret.yaml"

turkenf commented 12 months ago

/test-examples="examples/users/user.yaml"