crossplane-contrib / provider-upjet-azuread

AzureAD Provider for Crossplane.
https://marketplace.upbound.io/providers/upbound/provider-azuread/
Apache License 2.0
6 stars 19 forks source link

Deprecate process-fork related command-line flags #90

Closed ulucinar closed 12 months ago

ulucinar commented 1 year ago

Description of your changes

We are deprecating the following process-forking related command-line arguments:

What the user will see in the provider logs if she uses any of these flags is something like the following:

warning: Command-line flag "terraform-version" is deprecated and no longer used. It will be removed in a future release. Please remove it from all of your configurations (ControllerConfigs, etc.).
warning: Command-line flag "terraform-provider-source" is deprecated and no longer used. It will be removed in a future release. Please remove it from all of your configurations (ControllerConfigs, etc.).
warning: Command-line flag "terraform-provider-version" is deprecated and no longer used. It will be removed in a future release. Please remove it from all of your configurations (ControllerConfigs, etc.).
warning: Command-line flag "provider-ttl" is deprecated and no longer used. It will be removed in a future release. Please remove it from all of your configurations (ControllerConfigs, etc.).

These logs will be available even if the the debug logging is not enabled for the provider.

I have:

How has this code been tested

Tested manually via index.docker.io/ulucinar/provider-azuread:v0.14.0-c5866ef3f94acdd1d8cba067906191017eff701b and via uptest in https://github.com/upbound/provider-azuread/actions/runs/7035191432.

ulucinar commented 1 year ago

/test-examples="examples/applications/application.yaml"

ulucinar commented 1 year ago

/test-examples="examples/applications/application.yaml"

ulucinar commented 1 year ago

We also need to communicate this in our release notes. cc. @turkenf