search

crossplane-contrib / provider-upjet-gcp

Official GCP Provider for Crossplane by Upbound.
Apache License 2.0
60 stars 61 forks source link

Make MaxItems values consistent between JSON schema and provider schema #527

Closed sergenyalcin closed 1 month ago

sergenyalcin commented 1 month ago

Description of your changes

During tests of the `Convert all singleton lists in the MR APIs to embedded objects' PRs, we observed an issue regarding the inconsistency between the JSON schema and provider schema.

The GetProvider function returns provider configuration in the providers. This function has a parameter generationProvider. If it is set to true, the JSON schema is used to obtain provider configuration. If it is false, the Go schema is used.

In theory, the two schemas are equivalent. However, during tests, we observed inconsistencies in some fields MaxItems values. This means that we use different schemas during generation and reconciliation.

This causes issues with the conversion of singleton lists to embedded objects. This type of change may also cause bigger problems.

This PR makes MaxItems values consistent between JSON schema and provider schema by manipulating the resource schemas.

I have:

How has this code been tested

sergenyalcin commented 1 month ago

/test-examples="examples/composer/v1beta2/environment.yaml"

sergenyalcin commented 1 month ago

/test-examples="examples/compute/v1beta2/instancefromtemplate.yaml"

sergenyalcin commented 1 month ago

/test-examples="examples/container/v1beta2/nodepool.yaml"

sergenyalcin commented 1 month ago

This test failed because of timeout issue. The creation of the resource takes more than one hour. However, I checked the Console and the creation started. So it is good to go now. About the check-examples job please see this comment: https://github.com/crossplane-contrib/provider-upjet-gcp/pull/508#issuecomment-2115180493