jake-ciolek commented 2 weeks ago

Allow creating HMAC keys for GCP Cloud Storage.

This has been tested and applying the following results in a successful creation of a HMAC key. Its private key is written to the target namespace. To check on your machine, try out the example in:

examples/storage/v1beta1/hmackey.yaml

We at AlphaSense would appreciate if you could review this one as we rely on it for one of our internal initiatives.

Description of your changes

This adds the ability to manage GCP Cloud Storage HMAC keys through Crossplane.

There was an earlier pull request by someone else, see #261 which unfortunately got closed due to issues with Upjet and import cycles. Those issues were resolved since then.

I have:

[x] Read and followed Crossplane's [contribution process].
[x] Run make reviewable to ensure this PR is ready for review.
[x] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Ran make reviewable and also tried out the resource in my GCP project (creation, deletion and secret creation).

A successful uptest run: https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/9565894913

jeanduplessis commented 2 weeks ago

/test-examples="examples/storage/v1beta1/hmackey.yaml"

jeanduplessis commented 2 weeks ago

@jake-ciolek thank you for this contribution. The maintainers are on PTO this week, but we'll look at it when they are back and aim to release a new version of the provider before month end.

crossplane-contrib / provider-upjet-gcp

Add google_storage_hmac_key #546

Description of your changes

How has this code been tested

@jake-ciolek thank you for this contribution. The maintainers are on PTO this week, but we'll look at it when they are back and aim to release a new version of the provider before month end.