search

crossplane / addon-oam-kubernetes-local

Run OAM workloads on a Kubernetes cluster.
Apache License 2.0
21 stars 15 forks source link

move crossplane helm repo to alpha #21

Closed ryanzhang-oss closed 4 years ago

ryanzhang-oss commented 4 years ago

I assume that it's the last stable version

Sent from my T-Mobile 4G LTE Device

From: Lei Zhang (Harry) notifications@github.com Sent: Monday, April 27, 2020 9:56:43 PM To: crossplane/addon-oam-kubernetes-local addon-oam-kubernetes-local@noreply.github.com Cc: Ryan Zhang yangzhangrice@hotmail.com; Author author@noreply.github.com Subject: Re: [crossplane/addon-oam-kubernetes-local] move crossplane helm repo to alpha (#21)

@resouer commented on this pull request.

In README.mdhttps://github.com/crossplane/addon-oam-kubernetes-local/pull/21#discussion_r416326428:

-helm install crossplane --namespace crossplane-system crossplane-master/crossplane --version 0.9.0-rc +helm install crossplane --namespace crossplane-system crossplane-alpha/crossplane

The alpha chart does not have specific version?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/crossplane/addon-oam-kubernetes-local/pull/21#pullrequestreview-401497119, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AODXOHDHQ5PYWU7TCK52I2DROZOYXANCNFSM4MSK7SWQ.

wonderflow commented 4 years ago

@hasheddan Do you know why this PR is blocking? I can't merge it

hasheddan commented 4 years ago

@wonderflow it looks like GolangCI is having an issue, which could be because the service is being deprecated. I don't think I have admin on this repo but the webhook needs to be removed I think. @negz or @ryanzhang-oss might have access.

ryanzhang-oss commented 4 years ago

@wonderflow it looks like GolangCI is having an issue, which could be because the service is being deprecated. I don't think I have admin on this repo but the webhook needs to be removed I think. @negz or @ryanzhang-oss might have access.

How to disable the webhook?

hasheddan commented 4 years ago

@ryanzhang-oss it should be in the repo settings, do you have access?

ryanzhang-oss commented 4 years ago

@ryanzhang-oss it should be in the repo settings, do you have access?

I don't think so

hasheddan commented 4 years ago

@negz could you help out here?

jbw976 commented 4 years ago

I disabled the webhook for golangci and also disabled it as a required status check. This PR looks good to merge now @ryanzhang-oss @wonderflow @hasheddan

resouer commented 4 years ago

LGTM