Open rahulgrover99 opened 3 years ago
In the configuration_test.go
file I made this change:
prv := &pkgv1.Provider{ObjectMeta: metav1.ObjectMeta{Name: "negz-provider-nop"}}
to
prv := &pkgv1.Provider{ObjectMeta: metav1.ObjectMeta{Name: "crossplane-provider-nop"}}
which resulted in the following failure:
--- FAIL: TestConfiguration (130.15s)
/home/rg99/crossplane/conformance/crossplane/configuration_test.go:62: Created configuration "crossplane-conformance"
--- FAIL: TestConfiguration/DependencyBecomesInstalledAndHealthy (90.02s)
/home/rg99/crossplane/conformance/crossplane/configuration_test.go:169: Testing that the configuration's dependencies' Healthy and Installed status conditions become 'True'.
/home/rg99/crossplane/conformance/crossplane/configuration_test.go:192: Provider "crossplane-provider-nop" never became Healthy and Installed: timed out waiting for the condition
/home/rg99/crossplane/conformance/crossplane/configuration_test.go:76: Cleaning up configuration "crossplane-conformance".
/home/rg99/crossplane/conformance/crossplane/configuration_test.go:83: Deleted configuration "crossplane-conformance"
/home/rg99/crossplane/conformance/crossplane/configuration_test.go:65: Cleaning up provider "crossplane-provider-nop".
/home/rg99/crossplane/conformance/crossplane/configuration_test.go:72: Deleted provider "crossplane-provider-nop"
FAIL
FAIL github.com/crossplane/conformance/crossplane 130.169s
FAIL
Signed-off-by: Rahul Grover rahulgrover99@gmail.com
Description of your changes
Since provider-nop is ready to use, it might be a good idea to use the same for conformance tests. I have replaced occurrences of
negz/provider-nop
withcrossplane/provider-nop
and added essential spec required for the same.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
I've run the test on a local kind cluster running Crossplane 1.2. All the tests pass successfully except
TestConfiguration
. That might require updating the configuration image being used for the test.