Closed negz closed 3 years ago
Is there anything tracking the removal of these ignore statements in the future after this transitional period is done?
Only the TODOs, which I feel comfortable about in this context. :)
Successfully created backport PR #26 for release-1.2
.
Description of your changes
The defaulting of these fields will be introduced in crossplane-runtime v0.14 per https://github.com/crossplane/crossplane-runtime/pull/255. We'd like to support a transition period during which a provider may either specify the default or not. Unfortunately it's not easy to use cmp to test for "must be unset or value X" so I've just ignored the field for the time being
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
I've run
cd provider && go test .
against https://github.com/crossplane/provider-aws/commit/84acbf60bd68f2f7527c36dc3d23e955261bd932 (which is using a pre-release of runtime-0.14) and verified that the conformance tests tolerate the presence of the default fields.