init: omit controller image

crossplane / crossplane-cli

Tools and commands for managing and developing Crossplane

Apache License 2.0

14 stars 12 forks source link

init: omit controller image #45

Closed suskin closed 4 years ago

suskin commented 4 years ago

Related to crossplane/crossplane#1308

Now that we support omitting the controller image, it's easier as an author if we omit it.

Testing

Omitting the image field has been tested with other stacks; I tested it with the latest version of Crossplane and provider-gcp and stack-minimal-gcp on my machine.

I also tested generating the install.yaml locally by running the init command, and it came out as expected.

suskin commented 4 years ago

Does https://github.com/crossplane/crossplane-cli/pull/45/files#diff-95002115e9268c3ba814db1db532660dR164 need to be updated?

Yeah, good point. We should update that. In fact, we should go back and remove the override thing entirely, now that the stack manager will override the source for us. I'm not going to do that part in this PR though.