search

crossplane / crossplane

The Cloud Native Control Plane
https://crossplane.io
Apache License 2.0
9.38k stars 946 forks source link

Can't patch from composed resource status to the environment #5388

Closed negz closed 4 months ago

negz commented 7 months ago

What happened?

In v1.14 I refactored Crossplane's XR controller (including the native P&T implementation) to add support for composition functions. This introduced a regression: in v1.14 Crossplane doesn't patch from the observed state of a composed resource to the environment. It only patches from the desired state, per https://github.com/crossplane/crossplane/pull/5365#discussion_r1488348618.

How can we reproduce it?

Create a mode: Resources Composition that patches from a composed resource's status to the environment, then from the environment to another composed resource's spec.

What environment did it happen in?

Crossplane version: v1.14

negz commented 7 months ago

I think the urgency in fixing this regression is dependent on our plans for the feature in general, per https://github.com/crossplane/crossplane/issues/3770#issuecomment-1942824055. If we're going to drop support from native P&T soon it may not be worth fixing it up.

github-actions[bot] commented 4 months ago

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.