search

crossplane / docs

Repo for Crossplane documentation.
https://docs.crossplane.io
Other
49 stars 110 forks source link

Update version dropdown #767

Closed tr0njavolta closed 4 months ago

tr0njavolta commented 5 months ago

Fixes https://github.com/crossplane/docs/issues/765

netlify[bot] commented 5 months ago

Deploy Preview for crossplane ready!

Name Link
Latest commit b1f3517eb1713667903ceb79a7171cdea3cc90fc
Latest deploy log https://app.netlify.com/sites/crossplane/deploys/663a3188c75dde00089c863d
Deploy Preview https://deploy-preview-767--crossplane.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 1 paths audited
Performance: 83 (🟢 up 1 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

plumbis commented 5 months ago

That setting was there to be the "default" doc type to determine when to change the title bar and present the drop down menu.

In the "single-list" partial (that renders every page) the version drop down is here: https://github.com/crossplane/docs/blob/4566a907073f90a6ccb9c421503b4152e8acf0f0/themes/geekboot/layouts/partials/single-list.html#L22

The contrib guide and formerly the KB, they set this to false to hide the dropdown menu. https://github.com/crossplane/docs/blob/4566a907073f90a6ccb9c421503b4152e8acf0f0/content/contribute/_index.md?plain=1#L6

jbw976 commented 4 months ago

Thanks @plumbis for the explanation!! Let's go ahead and get this merged to fix this issue in production 🙏