Closed tr0njavolta closed 2 months ago
Name | Link |
---|---|
Latest commit | b4b9960ef347f8b926d833d369de8d51698e8726 |
Latest deploy log | https://app.netlify.com/sites/crossplane/deploys/6645287ec6ec290008dbf251 |
Deploy Preview | https://deploy-preview-773--crossplane.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 84 (🔴 down 1 from production) Accessibility: 90 (🔴 down 2 from production) Best Practices: 83 (no change from production) SEO: 93 (no change from production) PWA: 70 (no change from production) View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
Awesome thank you for taking this on @tr0njavolta! Does this address everything in #772, or a subset of that checklist? I'll start taking a deeper pass through now, including checking out the preview site to make sure functionality looks to be in the right place 😉
@jbw976 updated with the checklist and verified with the preview. API/CRD updates look good and version changes are in the right place.
The Vale issues I can tackle in a separate PR because that content was already present so there's probably a rule not applied in the new version that I can check out.
Create a new release/tag named "v-archive" to snapshot EOL'd docs.
I don't see the v1.13-archive
release/tag yet - do you? 🤔
Looks like the latest commit didn't have a sign-off, so the DCO check is failing: https://github.com/crossplane/docs/pull/773/checks?check_run_id=25023037420
Can you fix that up please? 🙏 this link may help: https://github.com/crossplane/crossplane/tree/master/contributing#certificate-of-origin
I don't see the v1.13-archive release/tag yet - do you? 🤔
This was a blocker for @tr0njavolta because they didn't have permissions to create a new release/tag in the Github UI. I created the release/tag at https://github.com/crossplane/docs/releases/tag/v1.13-archive
https://github.com/crossplane/docs/issues/772
Updates master with version 1.16