search

crossplane / docs

Repo for Crossplane documentation.
https://docs.crossplane.io
Other
49 stars 110 forks source link

Fix compositionrevision docs #792

Closed ezgidemirel closed 1 month ago

ezgidemirel commented 3 months ago

Description and context provided in https://github.com/crossplane/docs/pull/792#pullrequestreview-2266770668

netlify[bot] commented 3 months ago

Deploy Preview for crossplane ready!

Name Link
Latest commit 24129536a52de0cd978ee4a74060147661d3cad4
Latest deploy log https://app.netlify.com/sites/crossplane/deploys/66d586dad41d420008b59757
Deploy Preview https://deploy-preview-792--crossplane.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 1 paths audited
Performance: 82 (🔴 down 3 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

negz commented 1 month ago

@ezgidemirel Can you add some context around what this is fixing in the description please?

Some of the new changes are failing the Vale grammar linter (see the Checks tab). I suspect not all the warnings were actually introduced by this PR, but it may be worth trying to address some.

ezgidemirel commented 1 month ago

@ezgidemirel Can you add some context around what this is fixing in the description please?

Some of the new changes are failing the Vale grammar linter (see the Checks tab). I suspect not all the warnings were actually introduced by this PR, but it may be worth trying to address some.

As Jared mentioned, these changes were reverted accidentally some time ago.

I've fixed some of the vale errors. The remaining ones are spelling checks for words like CompositionRevisions, revision:1 etc..

ezgidemirel commented 1 month ago

@jbw976, I've rebased my PR :)