crossplane / oam-kubernetes-runtime

A set of libraries for building OAM runtimes
Apache License 2.0
277 stars 80 forks source link

[Feature] using trait type instead of hardcode word 'trait' to create trait CR #294

Closed wonderflow closed 4 years ago

wonderflow commented 4 years ago

image

$ kubectl get routes.standard.oam.dev
NAME                     AGE
myweb-trait-6ccc7c55c5   63m
testapp-trait-998b8f6f   46h

Expect behavior

$ kubectl get routes.standard.oam.dev
NAME                     AGE
myweb-route-6ccc7c55c5   63m
testapp-route-998b8f6f   46h
zzxwill commented 4 years ago

Please help assign it to me.

wonderflow commented 4 years ago

@zzxwill please make sure this is a compatible upgrade, which means, if user has already created a trait with the old naming rule and the spec didn't change , use the old name. Only the newly created trait will have the new name.