crossplane / provider-template

A template for building @crossplane providers.
https://crossplane.io
Apache License 2.0
134 stars 74 forks source link

make dev broken due to file removed from crossplane repository #104

Open MrVinkel opened 4 months ago

MrVinkel commented 4 months ago

What happened?

Hi, we have a couple of custom providers based on this template for some internal services.

The kustomization.yaml used in make dev was deleted from the crossplane repository a couple of days ago by @negz

https://github.com/crossplane/crossplane/commit/ea9e4393fd9081334b006fc275ec3de1738132a1

The yaml file is used by make dev to initialize the local development environment for the provider.

https://github.com/crossplane/provider-template/blob/main/Makefile#L95

I can use another ref to fetch the CRDs, but what is the permanent fix?

In general this provider template does not seem to get very much attention, and it is pretty rough to work with.

How can we reproduce it?

Create a new provider from this template and run make dev

What environment did it happen in?

Crossplane version:

Crossplane v1.16.0 Latest version of this provider

negz commented 4 months ago

I can use another ref to fetch the CRDs, but what is the permanent fix?

I don't think these CRDs are actually needed by the make dev target. My best guess is they were copied by mistake in https://github.com/crossplane/provider-template/pull/19. So that line could just be removed from the Makefile.

Off the top of my head, I can't think of any reason why installing a provider into a kind cluster would need Crossplane core CRDs to be installed. If I'm forgetting something, the Makefile could easily get the same CRDs installed by installing the Crossplane Helm chart per https://docs.crossplane.io/v1.16/software/install/#install-pre-release-crossplane-versions.

In general this provider template does not seem to get very much attention, and it is pretty rough to work with.

Yes, help wanted. I'm the only person listed in OWNERs.md who still works on Crossplane and I'm spread too thin to give this template the attention it deserves.