Closed phisco closed 9 months ago
We really need to convert these steps to dumb proof gh
commands 😅
Thanks for the PR @phisco! That PR fell through the cracks 🤦
One piece of feedback that looks to not have been incorporated was crossplane/crossplane#4871 (comment) - consider that one as well before merging, but its not blocking!
I was actually waiting for https://github.com/crossplane/crossplane/issues/4875 to be finalized and was planning to take the latest issue description there (e.g. edit and get raw markdown) and update my PR with it. @phisco feel free to do that, or leave this PR to me so that I can push a commit here on monday (assuming this can wait till then).
~Sure @turkenh, feel free to reopen a pr with it on Monday. Keeping this open just as a memo 👌~ Ported over the changes from https://github.com/crossplane/crossplane/issues/4875
Porting of the original commit from @turkenh: https://github.com/crossplane/crossplane/pull/4871