search

crossplane / terrajet

Generate Crossplane Providers from any Terraform Provider
https://crossplane.io
Apache License 2.0
290 stars 38 forks source link

logging package name conflict after generation #209

Closed ytsarev closed 2 years ago

ytsarev commented 2 years ago

What happened?

I encountered logging package conflict during the generation of https://github.com/AbsaOSS/provider-jet-rancher

17:27:05 [ .. ] golangci-lint
WARN [runner] Can't run linter goanalysis_metalinter: bodyclose: failed prerequisites: [buildssa@github.com/crossplane-contrib/provider-jet-rancher/internal/controller: analysis skipped: errors in package: [/Users/xxx/absa/provider-jet-rancher/internal/controller/zz_setup.go:43:2: logging redeclared in this block /Users/xxx/absa/provider-jet-rancher/internal/controller/zz_setup.go:23:2:   other declaration of logging /Users/xxx/absa/provider-jet-rancher/internal/controller/zz_setup.go:101:11: Setup not declared by package logging]]
WARN [runner] Can't run linter unused: buildir: analysis skipped: errors in package: [/Users/xxx/absa/provider-jet-rancher/internal/controller/zz_setup.go:43:2: logging redeclared in this block /Users/xxx/absa/provider-jet-rancher/internal/controller/zz_setup.go:23:2:    other declaration of logging /Users/xxx/absa/provider-jet-rancher/internal/controller/zz_setup.go:101:11: Setup not declared by package logging]
ERRO Running error: buildir: analysis skipped: errors in package: [/Users/xxx/absa/provider-jet-rancher/internal/controller/zz_setup.go:43:2: logging redeclared in this block /Users/xxx/absa/provider-jet-rancher/internal/controller/zz_setup.go:23:2:   other declaration of logging /Users/xxx/absa/provider-jet-rancher/internal/controller/zz_setup.go:101:11: Setup not declared by package logging]
17:27:17 [FAIL]

In the internal/controller/zz_setup.go we can observe two conflicting logging package imports

import (
...
    "github.com/crossplane/crossplane-runtime/pkg/logging"
...
    logging "github.com/crossplane-contrib/provider-jet-rancher/internal/controller/cluster/logging"

How can we reproduce it?

Clone https://github.com/AbsaOSS/provider-jet-rancher , make generate