search

crossplane / terrajet

Generate Crossplane Providers from any Terraform Provider
https://crossplane.io
Apache License 2.0
290 stars 38 forks source link

Confusion of `github_repository` in getting started doc #226

Closed zzxwill closed 2 years ago

zzxwill commented 2 years ago

What happened?

I got confused about github_repository in https://github.com/crossplane/terrajet/blob/main/docs/generating-a-provider.md?plain=1#L155. After that, I realized it refer to a Terraform resource of the provider.

Maybe we should make it more clear on github_repository.

How can we reproduce it?

turkenh commented 2 years ago

Thanks for the feedback @zzxwill

I hope 1db626737a33b38383077925152acb7dc22cac89 should fix this.

zzxwill commented 2 years ago

@turkenh It should. Thanks.

BTW, can you help take a look at this PR? https://github.com/crossplane/provider-alibaba/pull/72