Fixes the prefixes slice variable scope in GetSensitiveParameters()
During resolution of sensitive values in secret ref, https://github.com/crossplane/upjet/pull/406 introduced support for secret refs from initProvider fields, which introduced a prefixes slice to both check fieldpaths starting with spec.forProvider and spec.initProvider
In https://github.com/crossplane/upjet/pull/417, prefixes slice was modified in the case of fieldspaths starting with status.atProvider. in response to fix the associated issue.
However, prefixes slice (that is scoped outside of for loop) was being modified in the for loop for the case above, causing remaining iterations to unintentionally operate on modified slice, resulting some secretRef fields to be not resolved into the parameters, thus failing the resource create/update operations
Affected resources are those who have connection details mapping entries include a fieldpath with .status.atProvider followed by some .spec.forProvider and .spec.initProvider entries.
Description of your changes
Fixes the
prefixesslice variable scope in GetSensitiveParameters()During resolution of sensitive values in secret ref, https://github.com/crossplane/upjet/pull/406 introduced support for secret refs from
initProviderfields, which introduced aprefixesslice to both check fieldpaths starting withspec.forProviderandspec.initProviderIn https://github.com/crossplane/upjet/pull/417,
prefixesslice was modified in the case of fieldspaths starting withstatus.atProvider.in response to fix the associated issue.However,
prefixesslice (that is scoped outside of for loop) was being modified in the for loop for the case above, causing remaining iterations to unintentionally operate on modified slice, resulting some secretRef fields to be not resolved into the parameters, thus failing the resource create/update operationsAffected resources are those who have connection details mapping entries include a fieldpath with
.status.atProviderfollowed by some.spec.forProviderand.spec.initProviderentries.Related https://github.com/crossplane-contrib/provider-upjet-azure/pull/873
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Manually and uptest at: https://github.com/crossplane-contrib/provider-upjet-azure/pull/873