crossplane / upjet

A code generation framework and runtime for Crossplane providers
Apache License 2.0
296 stars 86 forks source link

A Terraform registry page for a group of related resources, results in only the first example generated #57

Closed donovanmuller closed 2 years ago

donovanmuller commented 2 years ago

What problem are you facing?

When there is Terraform registry page for a group of related resources (examples below), only the first example is generated.

Examples:

in the example above of the google_organization_iam related resources, only one example is generated in examples-generated, namely organizationiampolicy.yaml, which is the first example.

How could Terrajet help solve your problem?

Generate examples for all resources in the related group.

donovanmuller commented 2 years ago

In this example, for google_service_account_iam related resources, there is no example generated at all.

donovanmuller commented 2 years ago

This issue is more than likely the same as discussed in https://github.com/upbound/upjet/issues/43

muvaf commented 2 years ago

With https://github.com/upbound/official-providers/pull/515 , GCP should also have the unified examples where the whole HCL block is printed in a single YAML file. In Azure for example, this is already the case https://github.com/upbound/official-providers/blob/main/provider-azure/examples-generated/compute/windowsvirtualmachine.yaml

muvaf commented 2 years ago

https://github.com/upbound/official-providers/pull/515 is merged and we have this now.