crossplane / upjet

A code generation framework and runtime for Crossplane providers
Apache License 2.0
296 stars 86 forks source link

Random external name annotations got broken after injecting references into example manifests #68

Closed ezgidemirel closed 1 year ago

ezgidemirel commented 2 years ago

What happened?

Before enabling unified example manifests, we could be able to generate random names with RandRFC1123Subdomain.

kind: Bucket
metadata:
  annotations:
    crossplane.io/external-name: ${Rand.RFC1123Subdomain}
  name: example
spec:
  forProvider:
    region: us-west-1

Now, those annotations are displayed like below:

apiVersion: s3.aws.upbound.io/v1beta1
kind: Bucket
metadata:
  labels:
    testing.upbound.io/example-name: b
  name: b
spec:
  forProvider:
    region: us-west-1
    tags:
      Environment: Dev
      Name: My bucket

How can we reproduce it?

By checking provider-aws/examples-generated/s3/bucket.yaml after running make generate.

muvaf commented 1 year ago

I think this is fixed in a PR since I don't see it anymore in the example files.