add spec / fix warning / use CrossroadRegex

crossroadlabs / PathToRegex

A Swift library translating paths with wildcards into regular expressions

GNU General Public License v3.0

7 stars 7 forks source link

add spec / fix warning / use CrossroadRegex #5

Closed pgherveou closed 8 years ago

pgherveou commented 8 years ago

following up #4 Regex dep has been renamed CrossroadRegex am I right?

I added a #if to use the appropriate lib name (CrossroadRegex)
I fixed a warning to make pod lib lint pass

Let me know what you think!

dileping commented 8 years ago

@pgherveou Thanks a lot for your contribution. Will appreciate a lot if we could go through my comments. Let's make it the right way ;)

dileping commented 8 years ago

@pgherveou I think I have done my part here. You can now adapt your branch to resolve the conflicts (most probably you need to just leave the podspec and revert everything else).

Please note, that API quite some changed.

I'm waiting for your pod and one more PR from somebody on our team and will make the new release 0.3.0 as soon as everything is in place.

dileping commented 8 years ago

@pgherveou It says it has some conflicts. Could you resolve them so I could easily merge them, please?

pgherveou commented 8 years ago

Sorry stopped in the middle of it. I removed everything but the pod spec.

dileping commented 8 years ago

@pgherveou Thank you! Will create new release soon. Just make sure you're watching the project