search

crossroadlabs / Regex

Regular expressions for swift
Apache License 2.0
332 stars 33 forks source link

Stable Swift 4 support #41

Closed Coder-256 closed 7 years ago

Coder-256 commented 7 years ago

Pull if you want. Stable Swift 4 support, tagged 2.0.0. Now it is fully working.

ypopovych commented 7 years ago

Hi, @Coder-256 .

Thanks for PR. You did a lot of work.

I want to merge it, but I need several small changed from you:

  1. Sign our CLA, please.
  2. Restore links to our repo in the "README.md" file.

I will merge it and publish a new version.

Thanks, Yehor

Coder-256 commented 7 years ago

I already signed the CLA, but I think you or @dileping still has to. Also, I fixed the README.

ypopovych commented 7 years ago

Thanks.

Seems like a bug in clahub. Because we signed it too. (And I saw old PR from you, where you signed it).

I will check everything tomorrow and merge it.

Thanks, Yehor