search

crossroadlabs / Regex

Regular expressions for swift
Apache License 2.0
332 stars 33 forks source link

Swift 5 #48

Closed finestructure closed 5 years ago

finestructure commented 5 years ago

Updated targets for Swift 5 and bumped the swift versions where applicable.

I've set up Travis to run on the branch so hopefully the changes in .travis.yml work.

ypopovych commented 5 years ago

Hello,

Thank you for PR!

Can you, please, fix tests? From the first look, it's simply travis.yml fixes (setup proper test environments)

finestructure commented 5 years ago

Sure thing, I'll have a look!

finestructure commented 5 years ago

Alright, all sorted

ypopovych commented 5 years ago

One more comment. Seems as we can install swiftenv from the site, not from GitHub gist. Check https://swiftenv.fuller.li/en/latest/integrations/travis-ci.html

Can you update config?

finestructure commented 5 years ago

Ah yes, makes sense. Copied that around like an ancient relic and never checked back for updated installation instructions :)

finestructure commented 5 years ago

Are you planning on pushing out a new release soon?

If you're waiting for #47 - I'm happy to jump in and help with the rebase, seeing as most if not all the conflicts are due to my Swift 5 changes and it looks like adjusting that should be really straightforward when you're familiar with the changes.

ypopovych commented 5 years ago

Rebase it, if you can. I will create new release

finestructure commented 5 years ago

Here you go: #49