search

crossterm-rs / crossterm

Cross platform terminal library rust
MIT License
3.29k stars 280 forks source link

Add commands for scrolling region manipulation. #916

Closed nfachan closed 3 months ago

nfachan commented 3 months ago

One command sets the scrolling region, the other resets it to be the whole screen.

I don't know what to do about the pre-windows-10 winapi.

Is this something that can be implemented using the winapi? If not, what happens then? I'd love some guidance.

nfachan commented 3 months ago

The calling application is setting the region, scrolling, then resetting the region. So it probably makes sense to just change the commands to be something like ScrollRegionUp and ScrollRegionDown.

I'll attempt to make that change.

Thanks for the pointer to the Windows API documentation.

joshka commented 3 months ago

The calling application is setting the region, scrolling, then resetting the region. So it probably makes sense to just change the commands to be something like ScrollRegionUp and ScrollRegionDown.

I'll attempt to make that change.

Thanks for the pointer to the Windows API documentation.

I think what you have here is reasonable - mainly as it maps directly to an actual command that would be sent. Abstracting the region stuff might still be reasonable to do (I think it's probably not), but should be implemented as some sort of composite of the lower level commands you have here.

Putting my Ratatui hat on, having a scroll area work like this this might be really nice to experiment with.