search

crosstype / node-html-markdown

Fast HTML to markdown converter for NodeJS or the browser
163 stars 28 forks source link

[Contribution] Add new option for custom strike tag. #37

Closed robsonmafra closed 1 year ago

robsonmafra commented 2 years ago

@nonara , thank you for maintaining the node-html-markdown, it is saving lots of time.

I did a customisation for a use case I have converting HTML to "Markdown" for Slack ("mrkdwn") and I have one use case for the strike tag. For example, for Slack, it uses just one ~ instead of ~~.

Here a pull request to improve the library and allow to set a custom strike delimiter, similar to what you already uses for strong/bold.

nonara commented 2 years ago

Hi @robsonmafra . Sorry for the delay! I've been tied up for a few months.

Thank you for this submission! Looks great. I appreciate your sticking with our conventions and adding tests. Very nice work.

I will get this merged ASAP.