crossvertise / ActionMailerNext

Fork of ActionMailer.Net, A easy to use library to generate emails with razor views
MIT License
42 stars 24 forks source link

Changes from ActionMailer #1

Closed Eonasdan closed 10 years ago

Eonasdan commented 10 years ago

I started using your nuget/repo since the original is no longer updated. You've made some breaking changes that I'd like to suggest that "put back"

SetMailMethod is more annoying then the second point.

Thank you keeping this project maintained.

AndrewHK commented 10 years ago

Your first point is kind of already implemented as suggested (if SetMailMethod is not called, It will use SMTP by default in MailerBase.)

MailAttributes = mailAttributes ?? MailMethodUtil.GetAttributes();
MailSender = mailSender ?? MailMethodUtil.GetSender();

You have a fair point with the MainAttributes thing, We'll look into it soon.

Thanks for your feedback.

Eonasdan commented 10 years ago

ah ok. I had to look at the wiki for the usage instructions since it was different. Maybe the wiki should be modified to include a comment as such.

I also realized that the To and From want a MailAddress instead of a string so I'm going to have to change any migrated function over anyway. So, adding MailAttributesisn't going to be to much extra work.