Insert user defined js codes into extension object

crosswalk-project / crosswalk-ios

Crosswalk Project for iOS

https://crosswalk-project.org/

BSD 3-Clause "New" or "Revised" License

117 stars 77 forks source link

Insert user defined js codes into extension object #41

Closed jondong closed 9 years ago

jondong commented 9 years ago

Before this patch we've appended the user defined javascript codes after the auto generated stub codes, but it seems more convenient that we insert this part of codes into the extension object function.

jondong commented 9 years ago

@zliang7 PTAL

zliang7 commented 9 years ago

As you know, I'm no longer in charge of the project. So my comments is just for your information. You can merge any PR regardless of my opinions.

For this PR, it may work as you expect. But I don't think it's a good design. Free feel to break the API before beta and stable release.

zliang7 commented 9 years ago

I mean "feel free", sorry for typo.

jondong commented 9 years ago

@zliang7 PTAL again. your comments are addressed.

zliang7 commented 9 years ago

Much better. You have to merge it by yourself since I had dropped the privilege.