crosswalk-project / crosswalk

A web runtime built on Chrome. This project is currently unmaintained.
https://crosswalk-project.org/blog/crosswalk-final-release.html
BSD 3-Clause "New" or "Revised" License
2.32k stars 651 forks source link

Upgrade to chrome 60 #4001

Closed v3ss0n closed 5 years ago

v3ss0n commented 6 years ago

@rakuco Very nice to see crosswalk project moving onwards.

Can we upgrade crosswalk to chrome59 directly? It have many improvements : especially 20% average performance improvments for android.

rakuco commented 6 years ago

Erm, I don't think anyone has been working on Crosswalk for several months now, I only landed a patch or two to make sure it is still possible to check out the source code. Changing Chromium versions was one of the hardest parts of maintaining the project, so I don't think that's going to happen any time soon.

v3ss0n commented 6 years ago

should we try that? From the guides it seems quite straight forward for updating to downstream . https://github.com/crosswalk-project/crosswalk-website/wiki/Downstream-Chromium

rakuco commented 6 years ago

You're more than welcome to try :-) You should look at https://github.com/crosswalk-project/crosswalk-website/wiki/Rebasing-our-forks instead though.

v3ss0n commented 6 years ago

thanks , sorry i was looking at wrong link. I will give a try , had you tried before?

rakuco commented 6 years ago

Until Crosswalk stopped being maintained, yes.

v3ss0n commented 6 years ago

i am sorry , i thought it was not very hard .. are you interested to do if community can fund your effort?

rakuco commented 6 years ago

Not really, sorry, I already have a pretty demanding full-time day job :-)

v3ss0n commented 6 years ago

If anyone want to do that ? I will setup a bounty source.

Altiano commented 6 years ago

Chrome 60 has landed! It even has WebAssembly!

mcfarljw commented 6 years ago

I've spent a bit of time trying to get it rebased to Chrome 60. I ended up spawning a 32 vCPU Compute Engine Virtual Machine on Google to make compiling things faster. I've made progress, but it's still error after error and seems like it requires quite a bit of inside knowledge to really get it debugged and working.

v3ss0n commented 6 years ago

Wow , thank you so much @mcfarljw , There would be companies who would love to pay for your work , i would too . Can you set up a https://www.patreon.com/ or indiegogo or bountysource ? I am going to attract other companies who i know using xwalk too.

mcfarljw commented 6 years ago

I'll post back with more information later this coming week. If I feel that I've got enough of a "proof of concept" then I'll get a funding source created for those of you who want to help out. Right now I've just been adjusting things, but that has involved a lot of changes that I don't fully understand or commenting things out with notes just to keep the build process moving.

v3ss0n commented 6 years ago

i think people from the mailing list can help , some developers still respond there .

v3ss0n commented 6 years ago

@mcfarljw any update on this ? if prototype is ready should start for sourcing.

Githubxplabs commented 6 years ago

When will update?

jwriteclub commented 6 years ago

Hello all. We're continuing to move xwalk forward and are almost complete with v59 merge. We'll tackle v60 after that. Anyone else who would like to co-ordinate work please let us know. Also, we can sponsor build infrastructure for this as well. Reach out on github or hello@tenta.com.

v3ss0n commented 6 years ago

Very good , what kind of help needed let us know .

mcfarljw commented 6 years ago

Sorry for the delayed reply. My biggest issue has been getting things structured in a way that allows for quickly making and testing my changes. It's not quite as friendly as using hot reloading with webpack 😺

@jwriteclub I've just connected up with you via email.

v3ss0n commented 6 years ago

awesome thanks guys for working together , good!!

DevopsElectricJukebox commented 6 years ago

loving your work, we would be very interested in the update and assisting however we can @jwriteclub I have dropped you an email

ben-8409 commented 6 years ago

It's great you are stepping in here. We made the switch from Crosswalk to the native WebView and run into the issue of the many many non Google zertified phones out there (often from china, because the Google Services are not available there), that come with a customized WebView that is not updated throught the Play Store. Even recent phones as the UMI Z on Android 7.0 have a Chromium 52 WebView, but the biggest problem are Android 5 and 6 phones with even older WebViews. I believe until that is fixed, there still is a need for crosswalk and it is really great that you guys are stepping in. If there is a way to assist or if you have anything to share, for example when the v59 branch you have is ready to use, drop us a line!

v3ss0n commented 6 years ago

Thats is the main reason we cannot drop crosswalk , not in near future , may be forever. Thank you very much for continuing the work , please keep us posted.

Nexum1 commented 6 years ago

I'm so excited to see crosswalk staying up to date. I just wanted to thank you all for your contributions to this amazing project!

v3ss0n commented 6 years ago

how its going @jwriteclub @mcfarljw ??

Karolusrex commented 6 years ago

See this fork to stay up to date with the chrome version: https://github.com/Arva/cordova-plugin-crosswalk-webview

Nilos commented 6 years ago

Did not find any code in that fork that updates the chrome version.

v3ss0n commented 6 years ago

@Karolusrex what it is about? thats nothing to do with crosswalk but only to do with cordova crosswalk .

Karolusrex commented 6 years ago

Oh yeah right, it's cordova specific. It will automatically use the built-in WebView if newer version is detected, otherwise use crosswalk. Thought it could come in handy for anyone using cordova and trying to have a newer version of Chrome.

mcfarljw commented 6 years ago

@Karolusrex I like it, but one of the big problems is that although the version of Chrome might be newer you still can't develop for any specific version.

@v3ss0n Not much progress has been made on my part. I have put numerous weekend hours into it, but it is complex and compilation times are slow when testing. I sent @jwriteclub an email back in the day but haven't heard back from them about their progress on the project.

v3ss0n commented 6 years ago

@mcfarljw @jwriteclub if we raise funding , can you guys start working on this? May be to latest chrome? How much should we raise? I can afford about 1000$

mcfarljw commented 6 years ago

After looking at my previous work trying to rebase the project I don't think this is something someone without extensive knowledge of the chromium for android content shell or crosswalk (probably both) will be able to accomplish in a reasonable amount of time. I hope I'm wrong and will keep poking around hoping for a quick breakthrough, but already have a full time job and can't allot the amount of time required to this project right now.

v3ss0n commented 6 years ago

@rakuco can you help us? we could raise funds.

NaNgets commented 6 years ago

Hey @rakuco , I'm trying to learn about the process and to update it myself, I've followed the instructions at the rebasing tutorial, but I came across a few problems, and would appreciate your guidance. Please tell me if I did something wrong or what can I do to continue on the project.

What I've done is forked chromium-crosswalk, v8-crosswalk, crosswalk and libpxc, I've followed the instructions on creating the branches and upstream branches, now I have this directories: ~/xwalk ~/chromium-crosswalk ~/v8-crosswalk ~/libpxc

I've updated VERSION and DEPS.xwalk files, in DEPS.xwalk I've updated the chromium, v8 and buildtools revs, the crosswalk git and the libpxc rev.

Now trying to continue and following the instructions makes all kinds of errors, I'm trying to gclient sync and it says there's no .gclient, i'm trying all sorts of stuff but I'm not sure if I'm doing it correctly.

I think the directories should be one inside the other, i.e. xwalk and v8 should be in chromium-xwalk, is that right? I also didn't understand how to create the .gclient or .gclient-xwalk files, is there a special command for it? Is there something not in the rebasing tutorial that should be done, especially if I created a new machine for it, and did exactly as said?

I would appreciate any directions, tutorials, articles, links I can use and learn from.

Thanks!

v3ss0n commented 6 years ago

I am interested in it. i think we should email to crosswalk mailing list , there are more maintainers there : https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev

v3ss0n commented 6 years ago

@jwriteclub @mcfarljw can you check with @NaNgets , since he is willing to help , or keep on continuing what you left off.

hiepxanh commented 6 years ago

i can't see crosswalk current chrome version? is that chrome 53? My authentication with cookie login cannot work with chrome 63 below :( please, someone help to update this project. it beautiful and necessary, I can support money to someone continue working on this project.

rakuco commented 6 years ago

Now trying to continue and following the instructions makes all kinds of errors, I'm trying to gclient sync and it says there's no .gclient, i'm trying all sorts of stuff but I'm not sure if I'm doing it correctly.

I think the directories should be one inside the other, i.e. xwalk and v8 should be in chromium-xwalk, is that right? I also didn't understand how to create the .gclient or .gclient-xwalk files, is there a special command for it? Is there something not in the rebasing tutorial that should be done, especially if I created a new machine for it, and did exactly as said?

You have to start from https://crosswalk-project.org/contribute/building_crosswalk/linux_build.html, which contains all the information you need about gclient & co. It is better to familiarise yourself with the directory infrastructure (which is basically identical to Chromium's) before attempting to do any rebasing.

hiepxanh commented 6 years ago

what about raising fund? do you have any idea, sir?

rakuco commented 6 years ago

No, I'm not involved in any funding efforts.

NaNgets commented 6 years ago

Excellent, thank you, I'll try working on it a bit more on the weekend. I started going through the source code, it's really complex so I hope I'll get the grip on it soon.

Will poke when I have updates. Thanks!

v3ss0n commented 6 years ago

@hiepxanh i think we better pay directly to the contributors.

mcfarljw commented 6 years ago

@NaNgets I don't recommend jumping to Chrome 60 directly because so many things have changed and too much is broken. It might be easier to get Chrome 54 working, fix issues and then increment version by version.

NaNgets commented 6 years ago

Ok, i'll try a few things.

By the way, why is it always a few versions back? Why shouldn't it be aligned with the chromium webview's version?

v3ss0n commented 6 years ago

there are many custom patches , and things to make integration with cordova possible.

mcfarljw commented 6 years ago

@NaNgets It could be aligned with the latest chromium stuff, but this ticket was created more than half a year ago. Just getting it rebased to 60 would be a huge accomplishment. The original crosswalk development team always developed a version or two behind the current chromium release for stability reasons I think.

NaNgets commented 6 years ago

ok so some update: I got exhausted from my machine and the slow builds so I set up a server on AWS, somewhat like @mcfarljw did on google, it was really faster :)

I managed to fetch and build, however, when trying to execute ./xwalk ~/crosswalk-samples/hello-world/manifest.json I got this:

~/xwalk/src/out/Default/nacl_helper: error while loading shared libraries: libffmpeg.so: cannot open shared object file: No such file or directory [1:1:0223/121245:ERROR:nacl_fork_delegate_linux.cc(315)] Bad NaCl helper startup ack (0 bytes) [18052:18052:0223/121245:ERROR:browser_main_loop.cc(1377)] Unable to open X display.

Trying to google a bit I thought I need to install chromium's ffmpeg or set the NACL_ENV_PASSTHROUGH env variable, but no change was seen.

When building xwalk_builder and running ./xwalk_unittest - all tests passed, but running ./xwalk_browsertest failed a few.

Trying to follow the instructions on the crosswalk project site I didn't understand how to go from the build to install it on an app, should I build for android or linux is fine? how do I go about on using it on an app?

I would really appreciate any help and directions, or if someone from the original project can invest a little time with me for me to learn it and continue support on it on my own.

Thanks, NaNg.

rakuco commented 6 years ago

I recommend first building without NaCl support since it's always a PITA (i.e. pass enable_nacl=false in your GN args).

Trying to follow the instructions on the crosswalk project site I didn't understand how to go from the build to install it on an app, should I build for android or linux is fine? how do I go about on using it on an app?

It depends on where you want to run your app. If you're targeting Linux, you need to do exactly what you did. If you're creating an Android app, you need to build for Android and follow the instructions on the website to create an APK.

NaNgets commented 6 years ago

Update: Thanks @rakuco very much :) Currently I was able to build for android and got an APK (fyi, https://github.com/crosswalk-project/crosswalk-website/pull/354 isn't merged ;-) ), Still haven't check if the APK is good or not (and, just to mention, I'm still trying to get the current version to build, not a newer version), I'll have to do it later today or tomorrow.

Will update when I have more news, thanks! :) ~NaNg

v3ss0n commented 6 years ago

if you need someone to test your APK let me know. I would like to help too. This community should raise some funding for @NaNgets 's efforts! edit: so currently apk is chrome 56?

NaNgets commented 6 years ago

@v3ss0n currently it's still chrome 53, I will be able to continue my quest later today.