search

crosswalk-project / crosswalk

A web runtime built on Chrome. This project is currently unmaintained.
https://crosswalk-project.org/blog/crosswalk-final-release.html
BSD 3-Clause "New" or "Revised" License
2.33k stars 652 forks source link

[Android] screen.orientation should be supported on Android #648

Open yongsheng opened 11 years ago

yongsheng commented 11 years ago

The spec is here: https://dvcs.w3.org/hg/screen-orientation/raw-file/tip/Overview.html

For me, it should workable now. Need to verify it.

kenchris commented 11 years ago

Why? It is a Mozilla spec proposal that to my knowledge wasn't part of any working group. There was some negative feedback (from my and others) but unfortunately Samsung went ahead and just implemented this not standardized spec.

I believe the right way to solve this is https://www.w3.org/Bugs/Public/show_bug.cgi?id=23204

yongsheng commented 11 years ago

The link is from the internal doc. so we move to this one?

kenchris commented 11 years ago

I didn't understand you?

Let's keep the bug report open, but I am just saying that we shouldn't just go ahead implementing screen.orientation unless it seems likely to be standardized.

halton commented 11 years ago

@zliang7 is adding screen orientation for Tizen. AFAIK, it is not supported in content, as well as XWalk. I think it won't work on Android also.

yongsheng commented 11 years ago

@kenchris but it's our target this year. You can see the doc.

halton commented 11 years ago

@yongsheng, I know it is M3 goal for Tizen, does it valid for Android? Let's wait for @zliang7 to confirm whether his implementation can cover Android.

kenchris commented 11 years ago

@poussa @anssiko

zliang7 commented 11 years ago

@yongsheng @halton, Sorry, I can't confirm now. I need do some investigation for Android support. I have not started to implement the screen orientation API.

poussa commented 11 years ago

I would like to progress in implementing this API.

After reading the comments on the WHATWG mailing lists, http://lists.w3.org/Archives/Public/public-whatwg-archive/2013Jul/0135.html, I think we need this on the mobile devices for example for games which can be controlled via accelerometer. You must lock the screen orientation for those games. On the whatwg list, the non-supporting comments do not care about mobile use cases. We do.

Also, the requestFullscreen() API does not have the orientation lock attributes in place.

So I think we have the similar uses cases than FFOS and Tizen mobile which both have this API implemented.

xjiang45 commented 11 years ago

OK, @poussa. We will implement this screen orientation API on Crosswalk Tizen. The target milestone will be M4, since we need more time on the current implementation of Crosswalk rotation and device orientation API, to resolve some fundamental review comments and reach full coverage of the API spec, etc.

@yongsheng, for screen orientation API on crosswalk android, we assume it is not enabled. Zhenyu will be focusing on the general part and the Tizen integration. Is there someone to collaborate with Zhenyu and take care of the android integration part?

davidmaxwaterman commented 11 years ago

It seems there was no comment on the issue of implementing the API on crosswalk/android. Can we have some guidance on the timeframe involved? Thanks.

xjiang45 commented 11 years ago

The plan is @zliang7 will enable it on Crosswalk Tizen for M4, and the android team @yongsheng can have someone to collaborate with him on the android part.

yongsheng commented 11 years ago

according to the test, the screen orientation on Android is passed. Not sure it's the same feature. @ininallen any comments?

ininallen commented 11 years ago

@yongsheng actually for Android device it could be switch from portrait orientation to landscape orientation, orientation works well

xjiang45 commented 11 years ago

this is not just screen rotation. it is to comply with the spec of screen orientation API. so Crosswalk screen can rotate according to device orientation doesn't mean Crosswalk is fully complying with the spec. In another word, people need to look at the test cases and see whether they verify the API spec, not only check the API interface exists, but also check the API works actually.

yongsheng commented 11 years ago

ok, thanks for update. so suggest to close it?

xjiang45 commented 11 years ago

No, Yongsheng, the whole screen orientation API spec is not enabled in Chromium, and thus not in Crosswalk, either Tizen or Android. The plan for Tizen is Zhenyu will do the implementation targeting M4. So for Android, it would be great to have someone to collaborate with Zhenyu and enable it on Android side.

jiangwenhao commented 11 years ago

This feature has been migrated to JIRA, please track it in https://crosswalk-project.org/jira/browse/XWALK-162 . Thanks