Rescope extern C declaration to avoid compile errors

crosswire / xiphos

Xiphos is a Bible study tool written for Linux, UNIX, and Windows using GTK, offering a rich and featureful environment for reading, study, and research using modules from The SWORD Project and elsewhere.

http://xiphos.org

GNU General Public License v2.0

202 stars 52 forks source link

Rescope extern C declaration to avoid compile errors #1134

Closed ArrayBolt3 closed 9 months ago

ArrayBolt3 commented 9 months ago

Closes https://github.com/crosswire/xiphos/issues/1133 and https://github.com/crosswire/xiphos/issues/1083.

ArrayBolt3 commented 9 months ago

The test build failures are unrelated to the code change. There's some version detection logic in the CMake code that fails quite badly if the build is done outside of a Git repo with the proper tag(s). I'll file a bug report about that soon-ish.

Phyrik commented 3 months ago

@ArrayBolt3 I can't seem to find any issue/bug report regarding the test build failures, was the bug report ever filed?