search

crosswire / xiphos

Xiphos is a Bible study tool written for Linux, UNIX, and Windows using GTK, offering a rich and featureful environment for reading, study, and research using modules from The SWORD Project and elsewhere.
http://xiphos.org
GNU General Public License v2.0
202 stars 52 forks source link

Build with webkit2gtk 4.1 and libsoup3 #1139

Closed bgermann closed 5 months ago

bgermann commented 5 months ago

Forwarded from Debian:

Debian's webkit2gtk maintainers intend to stop building the 4.0 API soon. The 4.1 API is the same as the 4.0 API except that it uses libsoup3 instead of libsoup2.4.

Fedora has already stopped building the 4.0 API in preparation for the Fedora 40 release in a few months.

libsoup2 -> libsoup3 porting is sometimes complex. But in this case, I only made a minimal change and I was able to download a Bible translation with Xiphos and things appeared to work ok.

karlkleinpaste commented 5 months ago

@bgermann observation after the fact: building on f39, using -DGTKHTML=TRUE because we're (still) on the old editor, build succeeded but run crashed because both soup2 and soup3 were dyn.linked, causing soup3 to abort. turns out that using 4.0 in this circumstance was still the problem -- 4.0 requires soup2, 4.1 requires soup3. is there any reason why changing to 4.1 in this stanza would not also be correct?

  if (NOT WEBKIT1 AND GTKHTML)
    # Gtk+-3.0 + Webkit2 + WebKit-editor
    pkg_check_modules(Gtk REQUIRED IMPORTED_TARGET
      "gtk+-3.0"
      "webkit2gtk-4.1"
      "gtkhtml-editor-4.0"
      "libgtkhtml-4.0"
      )
  endif()
bgermann commented 5 months ago

As far as I can see this stanza will also need the update. I guess the patch submitter just tested with the Debian configuration and therefore only changed the relevant path for that.

karlkleinpaste commented 5 months ago

thx. i'll take care of it.