search

crosswire / xiphos

Xiphos is a Bible study tool written for Linux, UNIX, and Windows using GTK, offering a rich and featureful environment for reading, study, and research using modules from The SWORD Project and elsewhere.
http://xiphos.org
GNU General Public License v2.0
202 stars 52 forks source link

Handle tabs more like browsers do #1149

Closed nwalkewicz closed 1 week ago

nwalkewicz commented 1 month ago

This PR is based off of issue #1147.

In short, the purpose of this PR is to add various shortcuts/behaviors that make the tab system work a bit more as someone would expect coming from modern browsers. For a full list of changes, please see the original issue or refer to the names of these commits.

I ensured that formatting and code styles are as similar as the rest of the project as possible. Thank you for considering my contribution!

Closes #1147

nwalkewicz commented 1 month ago

I removed the Ctrl-PgUp/PgDown shortcuts for notebook_main because the shortcut seems to have already been used for the Standard/Parallel view's tabs.

nwalkewicz commented 1 month ago

In this PR's current state, there's some weird behavior when parallel tabs are rearranged. I think I know why; I'll mark this as a draft until I push a fix.

nwalkewicz commented 3 weeks ago

@karlkleinpaste Just fixed the issue I acknowledged in my last comment, would you mind reviewing this?

If you're curious, I just wrongly assumed tab positions were swapped and didn't account for them being shifted. Nothing to do with parallel tabs after all.

karlkleinpaste commented 2 weeks ago

i've had a weirdly busy week but i will check on this sometime over the weekend. sorry for delay.

nwalkewicz commented 2 weeks ago

No worries. Thank you!