search

crosswire / xiphos

Xiphos is a Bible study tool written for Linux, UNIX, and Windows using GTK, offering a rich and featureful environment for reading, study, and research using modules from The SWORD Project and elsewhere.
http://xiphos.org
GNU General Public License v2.0
202 stars 52 forks source link

CI fix broken dependencies #1151

Open Phyrik opened 1 month ago

Phyrik commented 1 month ago

Further commits for the same topic as #1150

@karlkleinpaste I don't know if you are comfortable with many pull requests for each change I make for each fix, or if you want to hold off on merging until I've got everything sorted, or if this should remain a draft pull request for the time being. Completely up to you.

karlkleinpaste commented 1 month ago

since it looks like you'll be changing things for a bit, i'll hold off until you tell me you're at a good endpoint or intermediate point. no sense overdoing it.

Phyrik commented 1 month ago

Sounds good, I'll mark this as a draft until I reckon you should merge it

Phyrik commented 1 month ago

The problem with Debian and Ubuntu (and likely the other distros, although they have other outstanding issues) is the deprecation of webkitgtk-3.0 (see #794) which is also preventing me from building on my Debian system.

The only reason the package in in the Debian repos is a patch from the maintainer removing the webkit editor (see here).

This seems to be a long standing issue with a lot of work needed to fix but at least it explains the failure of the CI builds.

karlkleinpaste commented 1 week ago

just curious, can you tell me where you are with this effort? i'm trying to get a few things accomplished (notably several PRs completed) and this remains in draft state. if it needs to wait, that's fine, i just wonder where you are, how far you've gotten.

Phyrik commented 1 week ago

Unfortunately I'm unable to make progress until we decide on a route to solve the webkitgtk debacle, since the reason the CI builds are failing is due to missing dependencies on said webkitgtk libraries.

I mentioned this at the start of the email I sent on the xiphos-devel mailing list, so you can refer to it for a more in depth explanation.

If you're happy with taking the route that Debian has (i.e. removing the components, notably the studypad, that require the webkitgtk dependencies) I'd be happy to do so, but it would be a large set of features to remove.

karlkleinpaste commented 3 days ago

i did respond to your email to xiphos-devel, and offered some explanation for what i thought i knew. perhaps i was off, but my belief was that webkitgtk was simply moving forward to a most-recent 4.1 version, hence recent commits to xiphos/cmake/XiphosDependencies.cmake, still distinguishable from the old versions that the windows build still needs.

looking at the latest build logs, it seems the fedora and arch failures are strictly on the version stamp:

CMake Error at CMakeLists.txt:73 (project):
  VERSION ".128" format invalid.

looking at the debian failure, it's unhappy with libenchant-dev; is this now missing, or renamed, or...? ubuntu is complaining about python-dev -- is this needing a version spec, such as perhaps python3-dev (i'm only a very casual ubuntu user)?

sorry if i'm being dense, but i don't see precisely what's gone wrong in this instant, specifically how it relates just to webkitgtk.

if the editor is the real base of the troubles, then #ifdef'ing it out (viz studypad and other editables) as a build-time choice would be ok, and let those features continue where the platform allows (fedora, at least).