crosswire / xiphos

Xiphos is a Bible study tool written for Linux, UNIX, and Windows using GTK, offering a rich and featureful environment for reading, study, and research using modules from The SWORD Project and elsewhere.
http://xiphos.org
GNU General Public License v2.0
208 stars 51 forks source link

2.3: failed footnote access in josephus #210

Closed xiphos-bug-inhaler closed 8 years ago

xiphos-bug-inhaler commented 17 years ago

in 2.2, showing josephus antiquities 18.3.3, there are 2 footnotes on the page; hovering on them gives dates in the previewer.

in 2.3, hovering on the same footnote markers, the previewer simply shows the title page of the josephus module, which seems to indicate that it got into the module properly but did not access a keyed footnote (or perhaps even the right section) properly.

Reported by: karlkleinpaste

Original Ticket: "gnomesword/bugs/209":https://sourceforge.net/p/gnomesword/bugs/209

xiphos-bug-inhaler commented 17 years ago

Logged In: YES user_id=34539 Originator: YES

it occurs to me that this is likely due to the same problem as is found in failing to get the HodgeSysTheo "About" box: the url is being mishandled because it contains embedded `/' which are encoded as %2F, and the combination of GS handling with MozEmbed interpretation is mangling this the same way. result is that the beginning of the url is fine, referencing the Josephus module, but the key content is damaged and so all that Sword can do is offer the beginning of the module instead of the key-specified section.

Original comment by: karlkleinpaste

xiphos-bug-inhaler commented 17 years ago

Logged In: YES user_id=34539 Originator: YES

fixed in -r1884. encode this, decode that, what a nightmare, i wish we could just consistently have things encoded or decoded and expect the final user of a string make the final determination of its disposition.

Original comment by: karlkleinpaste