Crash when starting with no commentaries

[xiphos-bug-inhaler]

When I start gnomesword 2.0 with no commentaries installed and no ~/.gnomesword-1.0 directory, it crashes just after displaying the main window. It appeas that xml_get_value returns null when the tag in question has no contents. history.c line 171 blindly passes the return value from xml_get_value("modules", "comm") to sprintf.

A similar crash occurs at line 169 if there are no bibles installed.

I am running Fedora Core 1. Overall it looks like quite an improvement since the 0.7x releases.

Andy andyhanton@comcast.net

Backtrace: 0x007abc32 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2

0 0x007abc32 in _dl_sysinfo_int80 () from

/lib/ld-linux.so.2

1 0x00a57a03 in __waitpid_nocancel () from

/lib/tls/libpthread.so.0

2 0x05fc77f4 in libgnomeui_module_info_get () from

/usr/lib/libgnomeui-2.so.0

3 <signal handler called>

4 0x008398c0 in strcpy () from /lib/tls/libc.so.6

5 0x08074ef7 in gui_add_history_Item (app=0x8532c48,

shortcut_bar=0x0, ref=0x84f3bd8 "Romans 8:28") at history.c:170

6 0x08072fd6 in frontend_display () at gnomesword.c:180

7 0x08090fbb in main (argc=0, argv=0xbfeb74b4) at

main.c:96

Thread 1 (Thread -1084534112 (LWP 22423)):

0 0x007abc32 in _dl_sysinfo_int80 () from

/lib/ld-linux.so.2 No symbol table info available.

1 0x00a57a03 in __waitpid_nocancel () from

/lib/tls/libpthread.so.0 No symbol table info available.

2 0x05fc77f4 in libgnomeui_module_info_get () from

/usr/lib/libgnomeui-2.so.0 No symbol table info available.

3 <signal handler called>

No symbol table info available.

4 0x008398c0 in strcpy () from /lib/tls/libc.so.6

No symbol table info available.

5 0x08074ef7 in gui_add_history_Item (app=0x8532c48,

shortcut_bar=0x0, ref=0x84f3bd8 "Romans 8:28") at history.c:170 i = 140854768

6 0x08072fd6 in frontend_display () at gnomesword.c:180

test = 134970888
info = (GS_DIALOG *) 0x0
str = (GString *) 0xbfeb74b4

7 0x08090fbb in main (argc=0, argv=0xbfeb74b4) at

main.c:96 newconfigs = 0 newbookmarks = 0

0 0x007abc32 in _dl_sysinfo_int80 () from

/lib/ld-linux.so.2

Reported by: *anonymous

Original Ticket: "gnomesword/bugs/71":https://sourceforge.net/p/gnomesword/bugs/71

[xiphos-bug-inhaler]

Logged In: YES user_id=3132

Thanks for your bug report. We'll look into it right away.

Original comment by: andyp

[xiphos-bug-inhaler]

Logged In: YES user_id=3132

Fixed in CVS

Original comment by: andyp