search

crosswire / xiphos

Xiphos is a Bible study tool written for Linux, UNIX, and Windows using GTK, offering a rich and featureful environment for reading, study, and research using modules from The SWORD Project and elsewhere.
http://xiphos.org
GNU General Public License v2.0
208 stars 51 forks source link

Misleading proximity of Strong's tags to the next line #990

Closed DavidHaslam closed 4 years ago

DavidHaslam commented 4 years ago

When (e.g.) Strong's numbers are enabled in module settings, the numbers are closer to the next line than to the line they actually belong to.

This is misleading to some extent.

Enabling Double spacing does not improve the matter. That only has any effect when there are no tags enabled.

LAfricain commented 4 years ago

Wow!!! 3 hours ago I wanted to open this issue!! But I had something urgent to do... And you did :) A picture can help:

strong_spacement

karlkleinpaste commented 4 years ago

heavy sigh this is an annoying artifact of webkit's varying-over-releases habits. i agree it's misleading to some extent, but the problem is that, as of just a couple xiphos releases ago, it was actually perfectly fine in placement, where the numbers (and lemmas) were well-positioned relative to base text.

i will see if i can improve on this with some adjustment to the stack specification, but it's not pretty, it's not reliable because of changing webkit habit, and it'll look wrong again in another year or two after webkit undergoes its own updates.

karlkleinpaste commented 4 years ago

i've now looked at this a bit, and without changing anything, the spacing looks to have become much more correct. this would indicate that (no surprise to me) webkit updates have occurred. here's several screenshots of 1Tim.3 in various Grk and Grk interlinear modes, with Strong's, lemmatization, and morphology. i think the spacing looks pretty good. unless someone gives me a good reason, i'm going to close this as some flavor of "unreproducible" or "fixed by other work" or whatever the relevant github-supported tag is.

screenshot1 screenshot2 screenshot3

LAfricain commented 4 years ago

Hi, Did you test with a bible only with strong numbers? With version of webkit are you speaking about?

karlkleinpaste commented 4 years ago

hm, well, the problem seems to be that I tested only with greek bibles, and perhaps my chosen greek font works better with the spacing.

looking now at NASB and KJV w/Strong's... yeah, it's still a problem.

pity. the greek modules look rather good.

LAfricain commented 4 years ago

Thank you Karl for this solution.