Make CFBundleIdentifier configurable.

crotwell / gradle-macappbundle

A Gradle Plugin to create a Mac OSX .app application and dmg based on the project.

Apache License 2.0

96 stars 33 forks source link

Make CFBundleIdentifier configurable. #29

Closed huxi closed 9 years ago

huxi commented 9 years ago

CFBundleIdentifier is currently hardcoded to mainClassName.

I'd suggest to add a bundleIdentifier property to MacAppBundlePluginExtension and use that if configured, with mainClassName being the fallback.

crotwell commented 9 years ago

Sounds reasonable. Using mainClassName was to be compatible with the Gradle Application plugin https://docs.gradle.org/current/userguide/application_plugin.html

huxi commented 9 years ago

It's definitely a reasonable default.

crotwell commented 9 years ago

Done in 2.1.1

huxi commented 9 years ago

Great! Thanks!