search

crotwell / gradle-macappbundle

A Gradle Plugin to create a Mac OSX .app application and dmg based on the project.
Apache License 2.0
96 stars 33 forks source link

Switch app launcher to one with a better JRE missing error? #61

Closed hepcat72 closed 5 years ago

hepcat72 commented 6 years ago

I was wondering if you'd be willing to swap out the standard oracle JavaAppLauncher strategy with one that yields a nicer error when the JRE is missing/inadequate. I found someone who did this for their project:

https://github.com/Fedict/eid-viewer/commit/1d1a31f23a29fc8426be728c78aa9059092d3a5c

I don't trust my users will understand the vague "JRELoadError" if they missed the java requirement in the documentation and we would rather not bundle a separate JRE.

crotwell commented 6 years ago

Seems like a reasonable idea. I would probably make it optional, so have a new "appStyle" like

macAppBundle {
  appStyle = 'universalJavaApplicationStub'
}

or something similar.

This would be a fairly big change, basically everywhere there is "Oracle" or "Apple" would have to have new code for this style.

Would you be able/interested in trying this and generating a pull request? I don't think I will have time to look at this anytime soon.

airsquared commented 5 years ago

@hepcat72 and @crotwell Is there progress on this?

hepcat72 commented 5 years ago

I haven’t adopted this. It was just a suggestion from my standpoint.

crotwell commented 5 years ago

Have not had time to look into this, so no progress. Happy to have a pull request if you are interested.

airsquared commented 5 years ago

@crotwell Done: #66. Just implemented and tested it and it works for me.