search

crow-misia / libmediasoup-android

libmediasoupclient for Android
Apache License 2.0
9 stars 9 forks source link

getting error when change webrtc version to `114.5735.3.0` #13

Closed ishabodiwala closed 1 year ago

ishabodiwala commented 1 year ago

Hello @crow-misia , I changed webrtc version to 114.5735.3.0, but my build gets failed with following errors.

/home/crow-misia/libmediasoup-android/core/deps/libmediasoupclient/src/Handler.cpp:212:36: error: no viable conversion from 'rtc::scoped_refptr<webrtc::RtpTransceiverInterface>' to 'webrtc::RtpTransceiverInterface *'
                  webrtc::RtpTransceiverInterface* transceiver = this->pc->AddTransceiver(track, transceiverInit);
                                                   ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/crow-misia/libmediasoup-android/core/deps/libmediasoupclient/src/Handler.cpp:359:30: error: assigning to 'webrtc::RtpSenderInterface *' from incompatible type 'rtc::scoped_refptr<RtpSenderInterface>'
                  sendResult.rtpSender     = transceiver->sender();
                                             ^~~~~~~~~~~~~~~~~~~~~
/home/crow-misia/libmediasoup-android/core/deps/libmediasoupclient/src/Handler.cpp:700:38: error: assigning to 'std::unordered_map<std::basic_string<char>, webrtc::RtpTransceiverInterface *>::mapped_type' (aka 'webrtc::RtpTransceiverInterface *') from incompatible type 'rtc::scoped_refptr<webrtc::RtpTransceiverInterface>'
                  this->mapMidTransceiver[localId] = transceiver;
                                                     ^~~~~~~~~~~

Am i missing something or we need to add patch for 114.5735.3.0 version ? Can you try this and make a recommendation for the same?

crow-misia commented 1 year ago

The reason it won't compile is because the webrtc interface has changed.

I think you need to create a patch.

I don't have time to this project.

ishabodiwala commented 1 year ago

Okay. I will try by adding patch. Thank you for your response.

neilyoung commented 1 year ago

@ishabodiwala Did you manage to solve this? Would you mind to share your solution?

neilyoung commented 1 year ago

...and it is not the only problem with M114 (understandably)

ishabodiwala commented 1 year ago

yes, we have also identified issues with other versions. However, we have not yet begun working on those issues.

neilyoung commented 1 year ago

It's easy to "fix". All the same problem